Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipc: avoid exception for empty paths #1092

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

brharrington
Copy link
Contributor

Fix StringIndexOutOfBoundsException if sanitize is called with an empty path string. Also updates the logic for / to be consistent with an empty path string. Both will now get sanitized to none as tag values cannot be empty.

Fix StringIndexOutOfBoundsException if sanitize is called
with an empty path string. Also updates the logic for `/`
to be consistent with an empty path string. Both will now
get sanitized to `none` as tag values cannot be empty.
@brharrington brharrington added this to the 1.7.1 milestone Nov 8, 2023
@brharrington brharrington requested a review from fedorka November 8, 2023 21:09
@brharrington brharrington modified the milestones: 1.7.1, 1.7.2 Nov 8, 2023
Copy link
Contributor

@fedorka fedorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast turnaround!

@brharrington brharrington merged commit fb69125 into Netflix:main Nov 8, 2023
1 check passed
@brharrington brharrington deleted the ipc-sanitize branch November 8, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants